Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Viewer2D: various orientation fixes #2212

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Sep 27, 2023

Description

In the 2D viewer, several widgets were not positioned properly when the exif orientation of the selected view was non-trivial:

  • color checker viewer
  • fisheye circle viewer
  • sphere detection viewer

This PR fixes these problems by making sure these widgets are parented to a QML Item with the proper size and location.

@mugulmd mugulmd added this to the Meshroom 2023.3.0 milestone Sep 27, 2023
@mugulmd mugulmd self-assigned this Sep 27, 2023
@cbentejac cbentejac merged commit dd04767 into develop Oct 5, 2023
2 checks passed
@cbentejac cbentejac deleted the mug/fixWidgetOrientation branch October 5, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants